From: Pedro Alves <pedro@palves.net>
To: Christina Schimpe <christina.schimpe@intel.com>,
gdb-patches@sourceware.org, Andrew Burgess <aburgess@redhat.com>
Subject: "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array)
Date: Wed, 20 Apr 2022 12:30:50 +0100 [thread overview]
Message-ID: <fd611206-1073-5dfe-4d00-20adb0d3c33e@palves.net> (raw)
In-Reply-To: <08fd8bbf-c44e-7313-d7b3-7b0770c2c7d4@palves.net>
On 2022-04-18 20:01, Pedro Alves wrote:
>
> (gdb) show remote X-packet
> Support for the 'p' packet on newly created remote targets is "disabled".
>
> and of course:
>
> (gdb) set remote X-packet disabled
> "on", "off" or "auto" expected.
>
>
> Also, BTW, err, why do we talk about the 'p' packet if the command is about
> the X packet? That's busted. Seems like a preexisting issue in current master.
I bisected this, and found out it was a regression introduced by this commit:
8579fd136a614985bd27f20539c7bb7c5a51287d is the first bad commit
commit 8579fd136a614985bd27f20539c7bb7c5a51287d
Author: Andrew Burgess <aburgess@redhat.com>
Date: Mon Nov 8 14:58:46 2021 +0000
gdb/gdbsupport: make xstrprintf and xstrvprintf return a unique_ptr
The motivation is to reduce the number of places where unmanaged
pointers are returned from allocation type routines. All of the
callers are updated.
There should be no user visible changes after this commit.
This commit is present in the GDB 12 branch and not in GDB 11, so it's a regression there.
next prev parent reply other threads:[~2022-04-20 11:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 13:11 [PATCH v2 0/3] Apply fixme notes for multi-target support Christina Schimpe
2022-03-29 13:11 ` [PATCH v2 1/3] gdb: Make global feature array a per-remote target array Christina Schimpe
2022-03-29 13:45 ` Eli Zaretskii
2022-04-18 14:56 ` Tom Tromey
2022-04-18 19:01 ` Pedro Alves
2022-04-20 11:30 ` Pedro Alves [this message]
2022-04-20 11:31 ` "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array) Pedro Alves
2022-04-21 10:25 ` Andrew Burgess
2022-04-21 10:31 ` Pedro Alves
2022-04-21 11:01 ` Andrew Burgess
2022-04-21 16:28 ` Andrew Burgess
2022-04-21 18:20 ` Pedro Alves
2022-04-27 13:55 ` [PATCH v2 1/3] gdb: Make global feature array a per-remote target array Schimpe, Christina
2022-05-25 14:27 ` Pedro Alves
2022-06-01 10:45 ` Schimpe, Christina
2022-03-29 13:11 ` [PATCH v2 2/3] gdb: Add per-remote target variables for memory read and write config Christina Schimpe
2022-03-29 13:48 ` Eli Zaretskii
2022-04-18 14:56 ` Tom Tromey
2022-03-29 13:11 ` [PATCH v2 3/3] gdb: Remove workaround for the vCont packet Christina Schimpe
2022-04-18 14:59 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd611206-1073-5dfe-4d00-20adb0d3c33e@palves.net \
--to=pedro@palves.net \
--cc=aburgess@redhat.com \
--cc=christina.schimpe@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).