public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Pedro Alves <pedro@palves.net>,
	Christina Schimpe <christina.schimpe@intel.com>,
	gdb-patches@sourceware.org
Subject: Re: "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array)
Date: Thu, 21 Apr 2022 12:01:10 +0100	[thread overview]
Message-ID: <87ilr2r98p.fsf@redhat.com> (raw)
In-Reply-To: <6fb9a140-0163-ce56-ac78-f5bf3f1b7795@palves.net>

Pedro Alves <pedro@palves.net> writes:

> On 2022-04-21 11:25, Andrew Burgess wrote:
>> Pedro Alves <pedro@palves.net> writes:
>>>
>>> This commit is present in the GDB 12 branch and not in GDB 11, so it's a regression there.
>> 
>> Sorry for the regression.  I took a look at the code and I honestly have
>> no idea why I thought the code in the above commit would work :-/
>> 
>
> No worries, happens all the time to me.  :-)
>
>> Below is a patch that should fix this issue.  I probably should write a
>> test to go along with it, but thought I'd share this for feedback first.
>> 
>> Let me know what you think,
>
> LGTM.  Thanks for fixing it.

Thanks, I'll just let a test run complete, and push this later today.

Thanks,
Andrew


  reply	other threads:[~2022-04-21 11:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29 13:11 [PATCH v2 0/3] Apply fixme notes for multi-target support Christina Schimpe
2022-03-29 13:11 ` [PATCH v2 1/3] gdb: Make global feature array a per-remote target array Christina Schimpe
2022-03-29 13:45   ` Eli Zaretskii
2022-04-18 14:56   ` Tom Tromey
2022-04-18 19:01   ` Pedro Alves
2022-04-20 11:30     ` "show remote foo-packet" regression (Re: [PATCH v2 1/3] gdb: Make global feature array a per-remote target array) Pedro Alves
2022-04-20 11:31     ` Pedro Alves
2022-04-21 10:25       ` Andrew Burgess
2022-04-21 10:31         ` Pedro Alves
2022-04-21 11:01           ` Andrew Burgess [this message]
2022-04-21 16:28             ` Andrew Burgess
2022-04-21 18:20               ` Pedro Alves
2022-04-27 13:55     ` [PATCH v2 1/3] gdb: Make global feature array a per-remote target array Schimpe, Christina
2022-05-25 14:27       ` Pedro Alves
2022-06-01 10:45         ` Schimpe, Christina
2022-03-29 13:11 ` [PATCH v2 2/3] gdb: Add per-remote target variables for memory read and write config Christina Schimpe
2022-03-29 13:48   ` Eli Zaretskii
2022-04-18 14:56   ` Tom Tromey
2022-03-29 13:11 ` [PATCH v2 3/3] gdb: Remove workaround for the vCont packet Christina Schimpe
2022-04-18 14:59   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilr2r98p.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=christina.schimpe@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).