* [PATCH 1/1] gdb: Document C++17 build requirement. @ 2024-02-19 14:56 Felix Willgerodt 2024-02-19 18:13 ` Lancelot SIX 0 siblings, 1 reply; 4+ messages in thread From: Felix Willgerodt @ 2024-02-19 14:56 UTC (permalink / raw) To: gdb-patches We require C++17 to build for a while now: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f74dc26792a0679e29db45e56367331ff48666d1 I also found another place we probably should update: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#C.2B-.2B-_dialect But I don't know how to do that. --- gdb/doc/gdb.texinfo | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index e4b89cfccfc..79805486dd6 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -40555,9 +40555,9 @@ Other packages will be used only if they are found. @heading Tools/Packages Necessary for Building @value{GDBN} @table @asis -@item C@t{++}11 compiler -@value{GDBN} is written in C@t{++}11. It should be buildable with any -recent C@t{++}11 compiler, e.g.@: GCC. +@item C@t{++}17 compiler +@value{GDBN} is written in C@t{++}17. It should be buildable with any +recent C@t{++}17 compiler, e.g.@: GCC. @item GNU make @value{GDBN}'s build system relies on features only found in the GNU -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] gdb: Document C++17 build requirement. 2024-02-19 14:56 [PATCH 1/1] gdb: Document C++17 build requirement Felix Willgerodt @ 2024-02-19 18:13 ` Lancelot SIX 2024-02-21 8:39 ` Willgerodt, Felix 0 siblings, 1 reply; 4+ messages in thread From: Lancelot SIX @ 2024-02-19 18:13 UTC (permalink / raw) To: Felix Willgerodt; +Cc: gdb-patches Hi Felix, Thank for catching this, I missed that part of the documentation when doing the C++17 migration. I have updated the wiki to reflect the C++17 requirement. Reviewed-By: Lancelot Six <lancelot.six@amd.com> Best, Lancelot. On Mon, Feb 19, 2024 at 03:56:55PM +0100, Felix Willgerodt wrote: > We require C++17 to build for a while now: > https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f74dc26792a0679e29db45e56367331ff48666d1 > > I also found another place we probably should update: > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#C.2B-.2B-_dialect > But I don't know how to do that. > > --- > gdb/doc/gdb.texinfo | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index e4b89cfccfc..79805486dd6 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -40555,9 +40555,9 @@ Other packages will be used only if they are found. > > @heading Tools/Packages Necessary for Building @value{GDBN} > @table @asis > -@item C@t{++}11 compiler > -@value{GDBN} is written in C@t{++}11. It should be buildable with any > -recent C@t{++}11 compiler, e.g.@: GCC. > +@item C@t{++}17 compiler > +@value{GDBN} is written in C@t{++}17. It should be buildable with any > +recent C@t{++}17 compiler, e.g.@: GCC. > > @item GNU make > @value{GDBN}'s build system relies on features only found in the GNU > -- > 2.34.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 1/1] gdb: Document C++17 build requirement. 2024-02-19 18:13 ` Lancelot SIX @ 2024-02-21 8:39 ` Willgerodt, Felix 2024-02-21 21:00 ` Tom Tromey 0 siblings, 1 reply; 4+ messages in thread From: Willgerodt, Felix @ 2024-02-21 8:39 UTC (permalink / raw) To: Lancelot SIX; +Cc: gdb-patches Thanks for fixing the wiki! I went ahead and pushed this under the "obvious" rule. I hope that is ok. Regards, Felix > -----Original Message----- > From: Lancelot SIX <lsix@lancelotsix.com> > Sent: Montag, 19. Februar 2024 19:14 > To: Willgerodt, Felix <felix.willgerodt@intel.com> > Cc: gdb-patches@sourceware.org > Subject: Re: [PATCH 1/1] gdb: Document C++17 build requirement. > > Hi Felix, > > Thank for catching this, I missed that part of the documentation when > doing the C++17 migration. > > I have updated the wiki to reflect the C++17 requirement. > > Reviewed-By: Lancelot Six <lancelot.six@amd.com> > > Best, > Lancelot. > > On Mon, Feb 19, 2024 at 03:56:55PM +0100, Felix Willgerodt wrote: > > We require C++17 to build for a while now: > > https://sourceware.org/git/?p=binutils- > gdb.git;a=commit;h=f74dc26792a0679e29db45e56367331ff48666d1 > > > > I also found another place we probably should update: > > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#C.2B- > .2B-_dialect > > But I don't know how to do that. > > > > --- > > gdb/doc/gdb.texinfo | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > > index e4b89cfccfc..79805486dd6 100644 > > --- a/gdb/doc/gdb.texinfo > > +++ b/gdb/doc/gdb.texinfo > > @@ -40555,9 +40555,9 @@ Other packages will be used only if they are found. > > > > @heading Tools/Packages Necessary for Building @value{GDBN} > > @table @asis > > -@item C@t{++}11 compiler > > -@value{GDBN} is written in C@t{++}11. It should be buildable with any > > -recent C@t{++}11 compiler, e.g.@: GCC. > > +@item C@t{++}17 compiler > > +@value{GDBN} is written in C@t{++}17. It should be buildable with any > > +recent C@t{++}17 compiler, e.g.@: GCC. > > > > @item GNU make > > @value{GDBN}'s build system relies on features only found in the GNU > > -- > > 2.34.1 > > > > Intel Deutschland GmbH > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > > Chairperson of the Supervisory Board: Nicole Lau > > Registered Office: Munich > > Commercial Register: Amtsgericht Muenchen HRB 186928 > > Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] gdb: Document C++17 build requirement. 2024-02-21 8:39 ` Willgerodt, Felix @ 2024-02-21 21:00 ` Tom Tromey 0 siblings, 0 replies; 4+ messages in thread From: Tom Tromey @ 2024-02-21 21:00 UTC (permalink / raw) To: Willgerodt, Felix; +Cc: Lancelot SIX, gdb-patches >>>>> Willgerodt, Felix <felix.willgerodt@intel.com> writes: > Thanks for fixing the wiki! > I went ahead and pushed this under the "obvious" rule. I hope that is ok. I think it is fine. Thank you for doing this. Tom ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-21 21:00 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-02-19 14:56 [PATCH 1/1] gdb: Document C++17 build requirement Felix Willgerodt 2024-02-19 18:13 ` Lancelot SIX 2024-02-21 8:39 ` Willgerodt, Felix 2024-02-21 21:00 ` Tom Tromey
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).