Re: [PATCH] Support the NO_COLOR environment variable

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> Tom Tromey <tom@tromey.com> writes:
>> I ran across this site:
>> 
>> https://no-color.org/
>> 
>> ... which lobbies for tools to recognize the NO_COLOR environment
>> variable and disable any terminal styling when it is seen.

Andrew> I've never understood the passionate hatred some folk have for coloured
Andrew> output!  But NO_COLOR sounds like a fairly reasonable request, so I'm in
Andrew> favour of adding this.  I did have some thoughts on the testing...

Me neither but it seems pretty simple to accommodate them.

>> -    if {$dumb_terminal} {
>> -	clean_restart $binfile
>> -    } else {
>> -	Term::clean_restart 24 80 $binfile
>> -	if {![Term::prepare_for_tui]} {
>> -	    unsupported "TUI not supported"
>> -	    return
>> +    global env
>> +    save_vars { env(TERM) } {
>> +	setenv TERM $terminal
>> +	if {$dumb_terminal} {
>> +	    clean_restart $binfile
>> +	} else {
>> +	    Term::clean_restart 24 80 $binfile
>> +	    if {![Term::prepare_for_tui]} {
>> +		unsupported "TUI not supported"
>> +		return
>> +	    }

Andrew> I'm not sure that this change is needed.

Something is needed here, because without this there are regressions.

Tom