Re: [PATCH] Support the NO_COLOR environment variable

[Eli Zaretskii <eliz@gnu.org>]

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom Tromey <tom@tromey.com>
> Date: Fri, 15 Sep 2023 18:09:08 -0600
> I ran across this site:
> 
>     https://no-color.org/
> 
> ... which lobbies for tools to recognize the NO_COLOR environment
> variable and disable any terminal styling when it is seen.
> 
> This patch implements this for gdb.

Should we also support the --color command-line argument, e.g. to
countermand NO_COLOR in the environment, and also as an alternative to
the environment variable?

> ---
>  gdb/NEWS                                       |  4 ++++
>  gdb/doc/gdb.texinfo                            |  3 +++
>  gdb/main.c                                     |  4 ++++
>  gdb/testsuite/gdb.base/early-init-file.exp     |  3 ++-
>  .../gdb.base/style-interp-exec-mi.exp          |  3 ++-
>  gdb/testsuite/gdb.base/style-logging.exp       |  3 ++-
>  gdb/testsuite/gdb.base/style.exp               |  9 ++++++---
>  .../build-id-no-debug-warning.exp              |  3 ++-
>  gdb/testsuite/gdb.debuginfod/crc_mismatch.exp  |  3 ++-
>  gdb/testsuite/gdb.python/py-format-string.exp  |  3 ++-
>  gdb/testsuite/gdb.python/py-source-styling.exp |  3 ++-
>  gdb/testsuite/gdb.python/py-startup-opt.exp    |  3 ++-
>  gdb/testsuite/gdb.rust/rust-style.exp          |  3 ++-
>  gdb/testsuite/gdb.tui/tui-layout.exp           | 18 +++++++++++-------
>  gdb/testsuite/lib/gdb.exp                      |  2 +-
>  gdb/testsuite/lib/tuiterm.exp                  |  3 ++-
>  16 files changed, 49 insertions(+), 21 deletions(-)

Thanks, the documentation parts of this are approved.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>