Re: [PATCH] Support the NO_COLOR environment variable

[Matt Rice <ratmice@gmail.com>]

On Sat, Sep 16, 2023 at 5:35 AM Eli Zaretskii via Gdb-patches
<gdb-patches@sourceware.org> wrote:
>
> > From: Tom Tromey <tom@tromey.com>
> > Cc: Tom Tromey <tom@tromey.com>
> > Date: Fri, 15 Sep 2023 18:09:08 -0600
> > I ran across this site:
> >
> >     https://no-color.org/
> >
> > ... which lobbies for tools to recognize the NO_COLOR environment
> > variable and disable any terminal styling when it is seen.
> >
> > This patch implements this for gdb.
>
> Should we also support the --color command-line argument, e.g. to
> countermand NO_COLOR in the environment, and also as an alternative to
> the environment variable?
>

I'm not sure a specific --color command-line argument is necessary,
the arg --early-init-eval-command 'set style enabled' (-eiex, which I
noticed is missing from --help.) works even when NO_COLOR is set,
appropriately printing colors in the non-quiet startup message.  So
even without something specific like --color it is possible to
override the env var.  IMO the need for specific commands for things
we want to happen early like `--quiet` vs `-eiex 'set
startup-quietly'` feel to me like holdovers from before
early evaluation existed when a specific command line arg like
`--quiet` needed early evaluation to have any effect.  But perhaps
that is just an opinion.