* [PATCH] gdb: add some missing filename styling
@ 2023-09-14 15:46 Andrew Burgess
2023-09-14 16:18 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Burgess @ 2023-09-14 15:46 UTC (permalink / raw)
To: gdb-patches; +Cc: Andrew Burgess
Spotted a few places where we can add filename styling.
---
gdb/symfile-debug.c | 11 +++++++----
gdb/symfile.c | 13 +++++++------
2 files changed, 14 insertions(+), 10 deletions(-)
diff --git a/gdb/symfile-debug.c b/gdb/symfile-debug.c
index 233cf3390e5..850da4147a3 100644
--- a/gdb/symfile-debug.c
+++ b/gdb/symfile-debug.c
@@ -34,6 +34,7 @@
#include "symfile.h"
#include "block.h"
#include "filenames.h"
+#include "cli/cli-style.h"
/* We need to save a pointer to the real symbol functions.
Plus, the debug versions are malloc'd because we have to NULL out the
@@ -542,16 +543,18 @@ objfile::require_partial_symbols (bool verbose)
{
if (verbose && !printed)
{
- gdb_printf (_("Reading symbols from %s...\n"),
- objfile_name (this));
+ gdb_printf (_("Reading symbols from %ps...\n"),
+ styled_string (file_name_style.style (),
+ objfile_name (this)));
printed = true;
}
iter->read_partial_symbols (this);
}
}
if (printed && !objfile_has_symbols (this))
- gdb_printf (_("(No debugging symbols found in %s)\n"),
- objfile_name (this));
+ gdb_printf (_("(No debugging symbols found in %ps)\n"),
+ styled_string (file_name_style.style (),
+ objfile_name (this)));
}
}
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 1b46ec45f2e..70ade9e119e 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -2322,8 +2322,8 @@ add_symbol_file_command (const char *args, int from_tty)
statements because hex_string returns a local static
string. */
- gdb_printf (_("add symbol table from file \"%s\""),
- filename.get ());
+ gdb_printf (_("add symbol table from file \"%ps\""),
+ styled_string (file_name_style.style (), filename.get ()));
section_addr_info section_addrs;
std::vector<sect_opt>::const_iterator it = sect_opts.begin ();
if (!seen_addr)
@@ -2369,8 +2369,8 @@ add_symbol_file_command (const char *args, int from_tty)
objf = symbol_file_add (filename.get (), add_flags, §ion_addrs,
flags);
if (!objfile_has_symbols (objf) && objf->per_bfd->minimal_symbol_count <= 0)
- warning (_("newly-added symbol file \"%s\" does not provide any symbols"),
- filename.get ());
+ warning (_("newly-added symbol file \"%ps\" does not provide any symbols"),
+ styled_string (file_name_style.style (), filename.get ()));
if (seen_offset)
set_objfile_default_section_offset (objf, section_addrs, offset);
@@ -2494,8 +2494,9 @@ reread_symbols (int from_tty)
new_modtime = new_statbuf.st_mtime;
if (new_modtime != objfile->mtime)
{
- gdb_printf (_("`%s' has changed; re-reading symbols.\n"),
- objfile_name (objfile));
+ gdb_printf (_("`%ps' has changed; re-reading symbols.\n"),
+ styled_string (file_name_style.style (),
+ objfile_name (objfile)));
/* There are various functions like symbol_file_add,
symfile_bfd_open, syms_from_objfile, etc., which might
base-commit: d7680f13df105aa8fa0edbdf8efae31a5411f579
--
2.25.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] gdb: add some missing filename styling
2023-09-14 15:46 [PATCH] gdb: add some missing filename styling Andrew Burgess
@ 2023-09-14 16:18 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2023-09-14 16:18 UTC (permalink / raw)
To: Andrew Burgess via Gdb-patches; +Cc: Andrew Burgess
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> Spotted a few places where we can add filename styling.
Thank you, this looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-14 16:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-14 15:46 [PATCH] gdb: add some missing filename styling Andrew Burgess
2023-09-14 16:18 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).