From: Tom Tromey <tom@tromey.com>
To: Alan Modra via Gdb-patches <gdb-patches@sourceware.org>
Cc: Alan Modra <amodra@gmail.com>, aburgess@redhat.com
Subject: Re: sim regen preparation
Date: Mon, 14 Aug 2023 10:26:12 -0600 [thread overview]
Message-ID: <87a5utzj2z.fsf@tromey.com> (raw)
In-Reply-To: <ZNoW3i3wUwYZ0WsF@squeak.grove.modra.org> (Alan Modra via Gdb-patches's message of "Mon, 14 Aug 2023 21:28:22 +0930")
>>>>> "Alan" == Alan Modra via Gdb-patches <gdb-patches@sourceware.org> writes:
Alan> Regerating sim loses commit 1be79b1ebfad from sim/lm32/cpu.h, a
Alan> generated file, so this patch move those declarations to
Alan> sim/lm32/sim-main.h.
In other spots in gdb we stick a read-only header on generated files to
avoid this sort of error, like:
/* THIS FILE IS GENERATED -*- buffer-read-only: t -*- */
/* vi:set ro: */
Pity cgen doesn't do this.
Alan> OK to apply?
I don't mind the patch at all but I wonder why cgen generates calls to
these functions but not declarations for them; whereas for other
functions (e.g., "lm32bf_h_pc_get") it does generate the declarations.
Tom
next prev parent reply other threads:[~2023-08-14 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 11:58 Alan Modra
2023-08-14 16:26 ` Tom Tromey [this message]
2023-08-16 3:07 ` Alan Modra
2023-08-16 3:51 ` Sam James
2023-08-16 13:20 ` Alan Modra
2023-08-16 17:47 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5utzj2z.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=amodra@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).