Re: sim regen preparation

[Alan Modra <amodra@gmail.com>]

On Mon, Aug 14, 2023 at 10:26:12AM -0600, Tom Tromey wrote:
> >>>>> "Alan" == Alan Modra via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Alan> Regerating sim loses commit 1be79b1ebfad from sim/lm32/cpu.h, a
> Alan> generated file, so this patch move those declarations to
> Alan> sim/lm32/sim-main.h.
> 
> In other spots in gdb we stick a read-only header on generated files to
> avoid this sort of error, like:
> 
> /* THIS FILE IS GENERATED -*- buffer-read-only: t -*- */
> /* vi:set ro: */
> 
> Pity cgen doesn't do this.

Yes, that would be nice.  Along with a whole lot of other things.  :)

> Alan> OK to apply?
> 
> I don't mind the patch at all but I wonder why cgen generates calls to
> these functions but not declarations for them; whereas for other
> functions (e.g., "lm32bf_h_pc_get") it does generate the declarations.

I'm not curious enough to dive down that rabbit hole, sorry.  The sim
patches I posted were enough for me to regen and run the testsuite, so
that eg. cpu/ patches can be regression tested on sim targets.  I also
looked at regenerated files in enough detail to convince myself that
the changes, in particular to iq2000, were reasonable.  

Note that people might have thought they were testing sim, but "make
check" in sim doesn't do much unless you set up site-sim-config.exp,
or have a lot of AS_FOR_TARGET_$arch, LD_FOR_TARGET_$arch and
CC_FOR_TARGET_$arch in your environment.  Also, linker warnings render
many of the tests "UNTESTED".  Only the latter is fixed, and of course
only for current warnings.

-- 
Alan Modra
Australia Development Lab, IBM