From: Tom Tromey <tromey@adacore.com>
To: Carl Love <cel@us.ibm.com>
Cc: Tom Tromey <tromey@adacore.com>,
Carl Love via Gdb-patches <gdb-patches@sourceware.org>,
Ulrich.Weigand@de.ibm.com
Subject: Re: [PATCH] gdb.ada/mi_var_access.exp
Date: Fri, 11 Aug 2023 14:35:28 -0600 [thread overview]
Message-ID: <87a5ux1fn3.fsf@tromey.com> (raw)
In-Reply-To: <9ba870d323b0d30ec36d4c3865ed937770d268ba.camel@us.ibm.com> (Carl Love's message of "Fri, 11 Aug 2023 10:14:24 -0700")
>>>>> "Carl" == Carl Love <cel@us.ibm.com> writes:
Carl> I see I have a typo above. The test is expecting 1, but it is 0 on
Carl> PowerPC, not 2 as stated above.
Carl> -var-create A_String_Access * A_String_Access
Carl> ^done,name="A_String_Access",numchild="0",value="0x0",type="pck.string_access",thread-id="1",has_more="0"
Ok, I see the problem. The test is kind of bogus:
A_String : String (3 .. 5) := "345"; -- STOP
... it stops at this line, but A_String may not be initialized here.
I think your patch is fine.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2023-08-11 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 19:26 Carl Love
2023-08-11 15:38 ` Tom Tromey
2023-08-11 17:14 ` Carl Love
2023-08-11 20:35 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ux1fn3.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).