RE: [PATCH] gdb.ada/mi_var_access.exp

[Carl Love <cel@us.ibm.com>]

Tom:
On Fri, 2023-08-11 at 09:38 -0600, Tom Tromey wrote:
> > > > > > "Carl" == Carl Love via Gdb-patches <
> > > > > > gdb-patches@sourceware.org> writes:
> 
> Carl> The following patch fixes two failures on PowerPC.  The test
> expects
> Carl> the value of NUMCHILD to always be 1 but on PowerPC it is 2.
> 
> What is the extra child?
> Seeing the MI output here might be informative.
> 
I see I have a typo above.  The test is expecting 1, but it is 0 on
PowerPC, not 2 as stated above.

(gdb) 
Expecting: ^(-var-create A_String_Access \* A_String_Access[^M
]+)?((\^done,name="A_String_Access",numchild="1",.*|\^error,msg="Value out of range.".*)[
]+[(]gdb[)] 
[ ]*)
-var-create A_String_Access * A_String_Access
^done,name="A_String_Access",numchild="0",value="0x0",type="pck.string_access",thread-id="1",has_more="0"
(gdb) 
FAIL: gdb.ada/mi_var_access.exp: Create varobj (unexpected output)


I have looked thru the log file for other places where numchild is
printed.  There is one other place which is after the second test
failure that the patch fixes.  In this case we get the expected value
of numchild:

(gdb) 
Expecting: ^(-var-update A_String_Access[
]+)?(\^done,changelist=\[\{name="A_String_Access",in_scope="true",type_changed="false",has_more="0"\}\][
]+[(]gdb[)] 
[ ]*)
-var-update A_String_Access
^done,changelist=[{name="A_String_Access",in_scope="true",type_changed="true",new_type="pck.string_access",new_num_children="1",has_more="0"}]
(gdb) 
FAIL: gdb.ada/mi_var_access.exp: update at stop 2 (unexpected output)

Expecting: ^(-var-list-children A_String_Access[]+)?(\^done,numchild="1",children=\[child=\{name="A_String_Access\.A_String_Access\.all",exp="A_String_Access\.all",numchild="3",type="array \(3 \.\. 5\) of character",thread-id="1"\}\],has_more="0"[
]+[(]gdb[)] 
[ ]*)
-var-list-children A_String_Access
^done,numchild="1",children=[child={name="A_String_Access.A_String_Access.all",exp="A_String_Access.all",numchild="3",type="array (3 .. 5) of character",thread-id="1"}],has_more="0"
(gdb) 
PASS: gdb.ada/mi_var_access.exp: list children at stop 2

In this case, the numchild value argrees with the expected output. 

                               Carl