Re: [PATCH 1/6 v2] gdb/debuginfod: Add debuginfod_section_query

[Andrew Burgess <aburgess@redhat.com>]

Andrew Burgess <aburgess@redhat.com> writes:

> Aaron Merey <amerey@redhat.com> writes:
>
>> v1: https://sourceware.org/pipermail/gdb-patches/2023-February/197455.html
>>
>> v2 improves the description of AC_DEBUGINFOD_SECTION and associated
>> macro names.  An if-statement in debuginfod_section_query is also
>> replaced with a gdb_assert.
>>
>> Commit message:
>>
>> Add new function debuginfod_section_query.  This function queries
>> debuginfod servers for an individual ELF/DWARF section associated with
>> a given build-id.
>>
>> Also check for libdebuginfod version >= 0.188 at configure time.
>> debuginfod_section_query simply returns -ENOSYS if this condition
>> is not met.
>
> This LGTM.
>
> I don't think this should be merged until there's a use for the new GDB
> functions (when later patches are also approved).
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>

Actually, on thinking about this further, I'd like to withdraw this
approval, and ask a question / make a suggestion:

Why do we need AC_DEBUGINFOD and AC_DEBUGINFOD_SECTION?  Couldn't you
just replace AC_DEBUGINFOD with AC_DEBUGINFOD_SECTION?  The SECTION
version checks for 0.179 and 0.188 and sets the various flags based on
whatever is found.

You would need to update binutils by running autoreconf, which would set
the new define, but binutils would just ignore that define and all would
be good.

I think I would split this first patch in two, the first part would
update the autoconf macro and then run autoreconf in binutils and gdb.
Cross post this to both mailing lists, and get this merged.

Then rebase this GDB series on top of that, and now GDB can just start
making use of the new #define.

Thanks,
Andrew