[PING][PATCH 5/6 v3] gdb/debuginfod: Support on-demand debuginfo downloading

[Aaron Merey <amerey@redhat.com>]

On Mon, Jul 10, 2023 at 5:01 PM Aaron Merey <amerey@redhat.com> wrote:
>
> On Fri, Jul 7, 2023 at 10:18 AM Andrew Burgess <aburgess@redhat.com> wrote:
> >   proc enable_section_downloads { } {
> >       global gdb_prompt
> >
> >       set cmd "maint set debuginfod download-sections on"
> >       set msg "enable section downloads"
> >
> >       return [gdb_test_multiple $cmd $msg {
> >         -re -wrap ".*not compiled into GDB.*" {
> >             return 0
> >         }
> >         -re -wrap "^" {
> >             return 1
> >         }
> >         -re -wrap "" {
> >             fail "$gdb_test_name (unexpected output)"
> >             return 0
> >         }
> >       }]
> >   }
> >
> > would do the job, though I don't currently have a machine with a recent
> > enough version of debuginfod installed to fully test this, but something
> > like this should do the job.
>
> Thanks Andrew, this works on my machine. I've updated the patch below with
> this change.

On Tue, Jul 11, 2023 at 11:00 AM Aaron Merey <amerey@redhat.com> wrote:
>
> On Tue, Jul 11, 2023 at 8:01 AM Pedro Alves <pedro@palves.net> wrote:
> >
> > Write:
> >
> >   catch (const gdb_exception &e)
> >
> > ... to avoid slicing.
> >
> > This catches QUIT exceptions as well.  Did you mean gdb_exception_error instead?
>
> Yes it should be gdb_exception_error. I've updated the patch with these changes.

Is this patch ready for merging with the above changes?

Aaron