public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: riscv: Make stack 16-byte aligned
Date: Fri, 12 Apr 2024 11:32:15 +0100	[thread overview]
Message-ID: <87bk6e6fdc.fsf@redhat.com> (raw)
In-Reply-To: <PAXP193MB1296432A56306213F013C1CDE4062@PAXP193MB1296.EURP193.PROD.OUTLOOK.COM>

Bernd Edlinger <bernd.edlinger@hotmail.de> writes:

> Various gcc test cases fail due to the stack
> alignment of 16 bytes is expected by gcc,

And indeed by the RISC-V ABI specification I believe.

> causing issues mostly with vararg functinos;

Typo: functions.

> e.g.
>
> FAIL: gcc.c-torture/execute/nest-align-1.c   -O0  execution test
> FAIL: gcc.c-torture/execute/nest-stdar-1.c   -O0  execution test
> FAIL: gcc.c-torture/execute/va-arg-12.c   -O0  execution test
> FAIL: gcc.c-torture/execute/va-arg-15.c   -O0  execution test
> FAIL: gcc.c-torture/execute/va-arg-16.c   -O0  execution test
> FAIL: gcc.c-torture/execute/va-arg-17.c   -O0  execution test
> FAIL: gcc.c-torture/execute/va-arg-20.c   -O0  execution test
> FAIL: gcc.c-torture/execute/va-arg-26.c   -O0  execution test
> ...
> ---
>  sim/riscv/sim-main.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
> index 4e3672505c6..0876d455570 100644
> --- a/sim/riscv/sim-main.c
> +++ b/sim/riscv/sim-main.c
> @@ -1586,6 +1586,8 @@ initialize_env (SIM_DESC sd, const char * const *argv, const char * const *env)
>    sp = sp_flat - ((argc + 1 + envc + 1) * sizeof (address_word));
>    /* Then the argc.  */
>    sp -= sizeof (unsigned_word);
> +  /* Align to 16 bytes.  */
> +  sp &= ~(address_word)15;

I think you should use 'align_down' from common/sim-bits.h, as:

  /* Align to 16 bytes.  */
  sp = align_down (sp, 15);

Assuming that works then:

Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks,
Andrew

>  
>    /* Set up the regs the libgloss crt0 expects.  */
>    riscv_cpu->a0 = argc;
> -- 
> 2.25.1


  reply	other threads:[~2024-04-12 10:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 12:09 Bernd Edlinger
2024-04-12 10:32 ` Andrew Burgess [this message]
2024-04-15  8:27   ` Bernd Edlinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bk6e6fdc.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).