From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Andrew Burgess <aburgess@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: riscv: Make stack 16-byte aligned
Date: Mon, 15 Apr 2024 10:27:55 +0200 [thread overview]
Message-ID: <AS8P193MB12852D3B7B9C681ED28B63C2E4092@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <87bk6e6fdc.fsf@redhat.com>
On 4/12/24 12:32, Andrew Burgess wrote:
> Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
>
>> Various gcc test cases fail due to the stack
>> alignment of 16 bytes is expected by gcc,
>
> And indeed by the RISC-V ABI specification I believe.
>
>> causing issues mostly with vararg functinos;
>
> Typo: functions.
>
>> e.g.
>>
>> FAIL: gcc.c-torture/execute/nest-align-1.c -O0 execution test
>> FAIL: gcc.c-torture/execute/nest-stdar-1.c -O0 execution test
>> FAIL: gcc.c-torture/execute/va-arg-12.c -O0 execution test
>> FAIL: gcc.c-torture/execute/va-arg-15.c -O0 execution test
>> FAIL: gcc.c-torture/execute/va-arg-16.c -O0 execution test
>> FAIL: gcc.c-torture/execute/va-arg-17.c -O0 execution test
>> FAIL: gcc.c-torture/execute/va-arg-20.c -O0 execution test
>> FAIL: gcc.c-torture/execute/va-arg-26.c -O0 execution test
>> ...
>> ---
>> sim/riscv/sim-main.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/sim/riscv/sim-main.c b/sim/riscv/sim-main.c
>> index 4e3672505c6..0876d455570 100644
>> --- a/sim/riscv/sim-main.c
>> +++ b/sim/riscv/sim-main.c
>> @@ -1586,6 +1586,8 @@ initialize_env (SIM_DESC sd, const char * const *argv, const char * const *env)
>> sp = sp_flat - ((argc + 1 + envc + 1) * sizeof (address_word));
>> /* Then the argc. */
>> sp -= sizeof (unsigned_word);
>> + /* Align to 16 bytes. */
>> + sp &= ~(address_word)15;
>
> I think you should use 'align_down' from common/sim-bits.h, as:
>
> /* Align to 16 bytes. */
> sp = align_down (sp, 15);
>
> Assuming that works then:
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>
>
> Thanks,
> Andrew
>
Okay, thanks for the hint about align_down.
So I changed that to:
sp = align_down (sp, 16);
and it worked...
Pushed.
Thanks
Bernd.
prev parent reply other threads:[~2024-04-15 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 12:09 Bernd Edlinger
2024-04-12 10:32 ` Andrew Burgess
2024-04-15 8:27 ` Bernd Edlinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8P193MB12852D3B7B9C681ED28B63C2E4092@AS8P193MB1285.EURP193.PROD.OUTLOOK.COM \
--to=bernd.edlinger@hotmail.de \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).