public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH 1/2] [gdb] Rename variable main_thread to main_thread_id
Date: Fri, 28 Jul 2023 07:06:55 -0600	[thread overview]
Message-ID: <87bkfwi3rk.fsf@tromey.com> (raw)
In-Reply-To: <20230728105945.13909-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 28 Jul 2023 12:59:44 +0200")

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> I noticed that the variable main_thread:
Tom> ...
Tom> /* The main thread.  */

Tom> static std::thread::id main_thread;
Tom> ...
Tom> has a confusing name and corresponding comment, because it doesn't contain the
Tom> main thread, but rather the main thread's std::thread::id.

Tom> Fix this by renaming to main_thread_id.

Thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

      parent reply	other threads:[~2023-07-28 13:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 10:59 Tom de Vries
2023-07-28 10:59 ` [PATCH 2/2] [gdb] Initialize main_thread_id earlier Tom de Vries
2023-07-28 13:10   ` Tom Tromey
2023-08-02 14:26     ` Tom de Vries
2023-08-02 16:55       ` Tom Tromey
2023-08-02 18:46         ` Tom de Vries
2023-08-02 20:48           ` Tom Tromey
2023-08-02 21:21             ` Tom de Vries
2023-07-28 15:36   ` Pedro Alves
2023-08-02 14:45     ` Tom de Vries
2023-07-28 13:06 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bkfwi3rk.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).