Re: [PATCH 2/2] [gdb] Initialize main_thread_id earlier

[Tom de Vries <tdevries@suse.de>]

On 7/28/23 15:10, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> I wrote a patch using is_main_thread (), and found it returning false in the
> Tom> main thread due to main_thread_id not being initialized yet.
> 
> Tom> Initialization currently takes place in _initialize_run_on_main_thread, but
> Tom> that's too late for earlier uses.
> 
> Tom> Fix this by also initializing on first use.
> 
> I wonder if it's enough to have:
> 
> static std::thread::id main_thread_id = std::this_thread::get_id ();
> 

In principle it's enough but it does expose us to the "Static 
Initialization Order Fiasco" [1], so I prefer this solution.

> Tom> +#if CXX_STD_THREAD
> Tom> +static void
> Tom> +initialize_main_thread_id (void)
> 
> "(void)" is only needed for C, you can just write "()" here.
> 

Ack, I'll update it in my reply to Pedro.

Thanks,
- Tom

[1] https://en.cppreference.com/w/cpp/language/siof