public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
	Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] [gdb] Initialize main_thread_id earlier
Date: Wed, 2 Aug 2023 23:21:12 +0200	[thread overview]
Message-ID: <7d705bdb-5984-b951-1ef4-bd06f8aae407@suse.de> (raw)
In-Reply-To: <874jlhcgr7.fsf@tromey.com>

On 8/2/23 22:48, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
>>> If we think it's safe enough to initialize it on first use, just
>>> moving
>>> the definition into is_main_thread is enough to avoid this problem.
>>>
> 
> Tom> Done.
> 
> This wasn't really what I meant but it's not important.
> 

Thanks for the review.

Sorry for misunderstanding this, if you'd like me to follow up in any 
way, let me know.

Committed.

Thanks,
- Tom

> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom


  reply	other threads:[~2023-08-02 21:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28 10:59 [PATCH 1/2] [gdb] Rename variable main_thread to main_thread_id Tom de Vries
2023-07-28 10:59 ` [PATCH 2/2] [gdb] Initialize main_thread_id earlier Tom de Vries
2023-07-28 13:10   ` Tom Tromey
2023-08-02 14:26     ` Tom de Vries
2023-08-02 16:55       ` Tom Tromey
2023-08-02 18:46         ` Tom de Vries
2023-08-02 20:48           ` Tom Tromey
2023-08-02 21:21             ` Tom de Vries [this message]
2023-07-28 15:36   ` Pedro Alves
2023-08-02 14:45     ` Tom de Vries
2023-07-28 13:06 ` [PATCH 1/2] [gdb] Rename variable main_thread to main_thread_id Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d705bdb-5984-b951-1ef4-bd06f8aae407@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).