From: Andrew Burgess <aburgess@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCHv3] gdb: add Python events for program space addition and removal
Date: Mon, 02 Oct 2023 17:09:03 +0100 [thread overview]
Message-ID: <87cyxxxazk.fsf@redhat.com> (raw)
In-Reply-To: <83wmw9x9qx.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andrew Burgess <aburgess@redhat.com>
>> Cc: Andrew Burgess <aburgess@redhat.com>,
>> Eli Zaretskii <eliz@gnu.org>,
>> Tom Tromey <tom@tromey.com>
>> Date: Fri, 29 Sep 2023 14:24:18 +0100
>>
>> In v3:
>>
>> - Rebased onto current master (there were some conflicts),
>>
>> - No other changes.
>>
>> Code is already approved, just needs a doc review.
>
> I thought I've reviewed this already?
:) I posted V2 on Wed and V3 on Fri (to resolve a merge-conflict during
a rebase). You reviewed both versions on Friday, for which I thank you!
>
> Anyway, the documentation parts are okay, thanks.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
I went ahead and pushed this patch.
Thanks,
Andrew
next prev parent reply other threads:[~2023-10-02 16:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 12:44 [PATCH] " Andrew Burgess
2023-09-21 19:20 ` Tom Tromey
2023-09-27 10:51 ` Andrew Burgess
2023-09-27 14:20 ` Tom Tromey
2023-09-27 15:17 ` Andrew Burgess
2023-09-27 15:16 ` [PATCHv2] " Andrew Burgess
2023-09-29 12:41 ` Eli Zaretskii
2023-09-29 13:24 ` [PATCHv3] " Andrew Burgess
2023-09-29 15:46 ` Eli Zaretskii
2023-10-02 16:09 ` Andrew Burgess [this message]
2023-10-02 18:34 ` Simon Marchi
2023-10-02 20:36 ` Andrew Burgess
2023-10-02 20:38 ` Simon Marchi
2023-10-02 21:17 ` Andrew Burgess
2023-10-02 20:11 ` [PUSHED] gdb/python: reformat file with black Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyxxxazk.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).