Re: [PATCH] gdb: add Python events for program space addition and removal

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> Initially I just wanted a Python event for when GDB removes a program
Andrew> space, I'm writing a Python extension that caches information for each
Andrew> program space, and need to know when I should discard entries for a
Andrew> particular program space.

Andrew> But, it seemed easy enough to also add an event for when GDB adds a
Andrew> new program space, so I went ahead and added both new events.

This approach seems totally fine to me, but it's worth noting that you
could attach data directly to a Progspace if the tp_hash field were
filled in.  Some other Python classes in gdb do this.  This makes caches
easier because the cleanup is automatic.

Andrew> +No @code{NewProgspaceEvent} is emitted for the very first program
Andrew> +space, which is assigned to the first inferior.  This first program
Andrew> +space is created within @value{GDBN} before and Python scripts are

Typo, "before any"

Other than that it looks good.

Approved-By: Tom Tromey <tom@tromey.com>

Tom