Re: [PATCH] gdb: add Python events for program space addition and removal

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

>> This approach seems totally fine to me, but it's worth noting that you
>> could attach data directly to a Progspace if the tp_hash field were
>> filled in.  Some other Python classes in gdb do this.  This makes caches
>> easier because the cleanup is automatic.

Andrew> I'm not sure I understand how tp_hash helps here?

Yeah, I meant tp_dictoffset ...

Andrew> gdb.Progspace does have a __dict__ attribute, so things like:

... which is already set.  Sorry about that.

Andrew> works just fine, and I did consider this.  But I wasn't sure if this was
Andrew> "good practice".  My concern was mostly that this might lead to clashes
Andrew> between different extensions if good names are not chosen for
Andrew> 'my_random_var', or even clashes between extensions and future GDB
Andrew> enhancements -- my understanding is that if we later added
Andrew> 'my_random_var' as a builtin attribute this would take precedence over
Andrew> the user defined attribute, breaking their extension.

Yeah.  gdb should promise not to use "_" names here & in other spots
using tp_dictoffset.

Tom