Re: [PATCH 3/3] gdb/infrun: handle stepping through functions with DW_AT_trampoline

[Tom Tromey <tom@tromey.com>]

>>>>> Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org> writes:

> This patch makes infrun continue stepping into and through trampoline
> functions marked via the DW_AT_trampoline in DWARF.  The attribute can
> be emitted by the compiler for certain subroutines/inlined subroutines
> that are compiler generated and should be hidden from a user.

Thank you for the patch.

I don't really know enough about infrun to comment on most of this patch.
It seems like a good idea to me.  It's close to a feature users have
wanted for a while -- an addition to the "skip" command to skip through
library-provided wrappers.

> +  add_setshow_boolean_cmd ("skip-trampoline-functions", class_run,
> +			  &skip_trampoline_functions, _("\
> +Set whether gdb attempts to hide trampolines marked in the debug info."), _("\
> +Show whether gdb attempts to hide trampolines marked in the debug info."), _("\
> +If on, while stepping gdb will skip through function trampolines and inlined\n\
> +fucntion trampolines that have been marked trampolines in the compiler's\n\

Typo, "function".  Also maybe "marked as trampolines by the compiler" instead.

> +debug info.  If off, gdb will ignore the DW_TAG_trampoline while stepping."),

I think this should probably not refer to DW_TAG_trampoline.
Few users will understand this.

thanks,
Tom