From: Tom Tromey <tom@tromey.com>
To: "George, Jini Susan via Gdb-patches" <gdb-patches@sourceware.org>
Cc: "Kempke, Nils-Christian" <nils-christian.kempke@intel.com>,
"George, Jini Susan" <JiniSusan.George@amd.com>
Subject: Re: [PATCH 1/3] gdb: add support for DW_AT_trampoline in DWARF reader
Date: Mon, 18 Jul 2022 10:11:18 -0600 [thread overview]
Message-ID: <87v8rul7tl.fsf@tromey.com> (raw)
In-Reply-To: <BY5PR12MB4965EFD9D2A79D16DD7263D4908D9@BY5PR12MB4965.namprd12.prod.outlook.com> (Jini Susan via Gdb-patches George's message of "Sun, 17 Jul 2022 12:57:57 +0000")
>>> I considered this when implementing it but it seemed like an unrelated change to
>>> me. Assuming int is 4 bytes and we align to 8 bytes moving is_trampoline to the
>>> 3rd position would also not do anything, would it? We'd be at
[...]
> I think you missed taking the bitfields (is_noreturn and
> is_trampoline) into consideration. If these get placed together, they
> would be fitted into one int since both these are just 1 bit each.
FWIW you can check the packing using 'ptype/o'.
I'm also inclined to say the bitfields should be adjacent.
thanks,
Tom
next prev parent reply other threads:[~2022-07-18 16:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 12:15 Nils-Christian Kempke
2022-07-07 12:15 ` [PATCH 2/3] gdb/symtab: add lookup for trampoline functions Nils-Christian Kempke
2022-07-15 20:13 ` Tom Tromey
2022-07-07 12:15 ` [PATCH 3/3] gdb/infrun: handle stepping through functions with DW_AT_trampoline Nils-Christian Kempke
2022-07-15 20:20 ` Tom Tromey
2022-07-13 7:39 ` [PATCH 1/3] gdb: add support for DW_AT_trampoline in DWARF reader George, Jini Susan
2022-07-13 11:59 ` Kempke, Nils-Christian
2022-07-17 12:57 ` George, Jini Susan
2022-07-18 16:11 ` Tom Tromey [this message]
2022-07-15 20:05 ` Tom Tromey
2023-01-03 1:07 Ijaz, Abdul B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8rul7tl.fsf@tromey.com \
--to=tom@tromey.com \
--cc=JiniSusan.George@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=nils-christian.kempke@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).