Re: [PATCH] gdb/python: restrict the names accepted by gdb.register_window_type

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> In the end I figured it might make sense to place some restrictive
> Andrew> rules in place, and then relax the rules later if/when users complain,
> Andrew> we can consider each relaxation as its requested.
>
> Andrew> So, I propose that window names should match this regular expression:
>
> Andrew>   [a-zA-Z][-_.a-zA-Z0-9]*
>
> Makes sense to me.
>
> Andrew> There is a chance that there is user code in the wild which will break
> Andrew> with the addition of this change, but hopefully adapting to the new
> Andrew> restrictions shouldn't be too difficult.
>
> It's possible but I wouldn't worry about it.
>
> This patch looks good to me.

Thanks, pushed.

Andrew