From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb/python: restrict the names accepted by gdb.register_window_type
Date: Wed, 21 Sep 2022 08:42:44 -0600 [thread overview]
Message-ID: <87wn9w4wm3.fsf@tromey.com> (raw)
In-Reply-To: <20220914142904.1071745-1-aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Wed, 14 Sep 2022 15:29:04 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> In the end I figured it might make sense to place some restrictive
Andrew> rules in place, and then relax the rules later if/when users complain,
Andrew> we can consider each relaxation as its requested.
Andrew> So, I propose that window names should match this regular expression:
Andrew> [a-zA-Z][-_.a-zA-Z0-9]*
Makes sense to me.
Andrew> There is a chance that there is user code in the wild which will break
Andrew> with the addition of this change, but hopefully adapting to the new
Andrew> restrictions shouldn't be too difficult.
It's possible but I wouldn't worry about it.
This patch looks good to me.
Tom
next prev parent reply other threads:[~2022-09-21 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 14:29 Andrew Burgess
2022-09-21 14:42 ` Tom Tromey [this message]
2022-09-22 9:42 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn9w4wm3.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).