Re: [PATCH] process-dies-while-detaching.exp: Exit early if GDB misses sync breakpoint

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Andrew Burgess <aburgess@redhat.com> writes:

> Thiago Jung Bauermann via Gdb-patches <gdb-patches@sourceware.org>
> writes:
>
>> I'm seeing a lot of variability in the failures of
>> gdb.threads/process-dies-while-detaching.exp on aarch64-linux.  On this
>> platform, a problem yet to be investigated causes GDB to miss the _exit
>> breakpoint.  What happens next is random because after missing that
>> breakpoint, GDB is out of sync with the inferior.  This causes the tests
>> following that point in the testcase to fail in a random way.
>>
>> In this scenario it's better to exit the testcase early to avoid random
>> results in the testsuite.
>>
>> We are relying on gdb_continue_to_breakpoint to return the result of
>> gdb_test_multiple.  This is already the case because in Tcl the return
>> value of a function is the return value of the last command it runs.  But
>> change gdb_continue_to_breakpoint to explicitly return this value, to make
>> it clear this is the intended behaviour.
>>
>> Tested on aarch64-linux.
>
> Looks great.  Thanks for improving this.
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>

Thank you! Pushed as commit 0f3efefb34f8.

-- 
Thiago