Re: [PATCH] process-dies-while-detaching.exp: Exit early if GDB misses sync breakpoint

[Thiago Jung Bauermann <thiago.bauermann@linaro.org>]

Guinevere Larsen <blarsen@redhat.com> writes:

> On 29/09/2023 19:53, Thiago Jung Bauermann via Gdb-patches wrote:
>> I'm seeing a lot of variability in the failures of
>> gdb.threads/process-dies-while-detaching.exp on aarch64-linux.  On this
>> platform, a problem yet to be investigated causes GDB to miss the _exit
>> breakpoint.  What happens next is random because after missing that
>> breakpoint, GDB is out of sync with the inferior.  This causes the tests
>> following that point in the testcase to fail in a random way.
>>
>> In this scenario it's better to exit the testcase early to avoid random
>> results in the testsuite.
> Thanks for working on this test, it has been driving me up the wall for a while!

Yes, this caused a few false positives in our CI. :-/

>> We are relying on gdb_continue_to_breakpoint to return the result of
>> gdb_test_multiple.  This is already the case because in Tcl the return
>> value of a function is the return value of the last command it runs.  But
>> change gdb_continue_to_breakpoint to explicitly return this value, to make
>> it clear this is the intended behaviour.
> I like this change, since I didn't actually know that this was TCL's behavior!

Tcl works in mysterious ways. :-)

>> Tested on aarch64-linux.
>
> I tested on x86_64 and I see no regressions.
>
> Tested-By: Guinevere Larsen <blarsen@redhat.com>

Thank you for testing!

> I hope this gets approved soon!

Me too. :-)

-- 
Thiago