From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH v2 0/7] Reimplement DAP backtrace using frame filters
Date: Mon, 26 Jun 2023 09:07:58 -0600 [thread overview]
Message-ID: <87ilbaxnw1.fsf@tromey.com> (raw)
In-Reply-To: <20230614-dap-frame-decor-v2-0-10628dfa6b60@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 22 Jun 2023 10:19:26 -0600")
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> - Removed is_constant check from FrameVars
This particular change caused a regression in the relatively new DAP
"scopes" test, because that test has:
static int scalar = 23;
... which is not used at all. This causes GCC to emit it as a constant.
Now, I tend to think this change is a good one, because I think
including enumeration constants in the locals output is not very useful,
and because the above scenario isn't one that is likely to happen in
real code.
Another solution might be to find a way to eliminate enumeration
constants from the output without affecting other local constants.
Meanwhile, locally I've updated the scopes test to use the variable in
question.
But, do let me know what you think. It would be convenient if I could
land my remaining DAP patches.
Tom
next prev parent reply other threads:[~2023-06-26 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 16:19 Tom Tromey
2023-06-22 16:19 ` [PATCH v2 1/7] Fix execute_frame_filters doc string Tom Tromey
2023-06-22 16:19 ` [PATCH v2 2/7] Add new interface to frame filter iteration Tom Tromey
2023-06-22 16:19 ` [PATCH v2 3/7] Fix oversights in frame decorator code Tom Tromey
2023-06-22 16:19 ` [PATCH v2 4/7] Simplify FrameVars Tom Tromey
2023-06-26 15:02 ` Tom Tromey
2023-06-22 16:19 ` [PATCH v2 5/7] Reimplement DAP stack traces using frame filters Tom Tromey
2023-06-22 16:19 ` [PATCH v2 6/7] Handle typedefs in no-op pretty printers Tom Tromey
2023-06-22 16:19 ` [PATCH v2 7/7] Add Ada scope test for DAP Tom Tromey
2023-06-26 15:07 ` Tom Tromey [this message]
2023-07-10 19:14 ` [PATCH v2 0/7] Reimplement DAP backtrace using frame filters Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ilbaxnw1.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).