Re: [PATCH v2 4/7] Simplify FrameVars

[Tom Tromey <tromey@adacore.com>]

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> FrameVars implements its own variant of Symbol.is_variable and/or
Tom> Symbol.is_control.  This patch replaces this code.

Tom> -        # SYM may be a string instead of a symbol in the case of
Tom> -        # synthetic local arguments or locals.  If that is the case,
Tom> -        # always fetch.
Tom> -        if isinstance(sym, str):
Tom> -            return True

I noticed that I removed this check.

However, looking into it, I think there's no way for this to happen,
because FrameVars is only ever instantiated with a real gdb.Frame, and
these won't return synthetic locals.

Tom