public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>,
	Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: remove unnecessary 'dir' commands from gdb-gdb.gdb script
Date: Sat, 11 Feb 2023 17:15:34 +0000	[thread overview]
Message-ID: <87k00ounrd.fsf@redhat.com> (raw)
In-Reply-To: <87y1p7ym2w.fsf@tromey.com>

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> While debugging GDB I used 'show directories' and spotted lots of
> Andrew> entries that didn't make much sense. Here are all the entries that are
> Andrew> in my directories list:
>
> Andrew> However... I'd like to propose that we instead remove all the extra
> Andrew> directories completely.  My hope is that, with more recent tools, the
> Andrew> debug information should allow us to correctly find all of the source
> Andrew> files without having to add any extra 'dir' entries.  Obviously,
> Andrew> commit 67f0714670383a does make me a little nervous, but the
> Andrew> gdb-gdb.gdb script isn't something a non-maintainer will be using, so
> Andrew> I think we can afford to be a little more aggressive here.  If it
> Andrew> turns out the 'dir' entries are needed then we can add them back, but
> Andrew> actually document why they are needed.  Plus, when we add them back we
> Andrew> will use @abs_srcdir@ instead of @srcdir@.
>
> Makes sense to me.

Thanks.  I've pushed this.  I'm sure people will shout if it turns out
these were useful in someway.

Thanks,
Andrew


      reply	other threads:[~2023-02-11 17:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 17:13 Andrew Burgess
2023-02-09 14:01 ` Tom Tromey
2023-02-11 17:15   ` Andrew Burgess [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k00ounrd.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).