From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdb: remove unnecessary 'dir' commands from gdb-gdb.gdb script
Date: Thu, 09 Feb 2023 07:01:27 -0700 [thread overview]
Message-ID: <87y1p7ym2w.fsf@tromey.com> (raw)
In-Reply-To: <51bcb8afd665fed00ce44e7eb33846d8444feea9.1675876331.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Wed, 8 Feb 2023 17:13:46 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> While debugging GDB I used 'show directories' and spotted lots of
Andrew> entries that didn't make much sense. Here are all the entries that are
Andrew> in my directories list:
Andrew> However... I'd like to propose that we instead remove all the extra
Andrew> directories completely. My hope is that, with more recent tools, the
Andrew> debug information should allow us to correctly find all of the source
Andrew> files without having to add any extra 'dir' entries. Obviously,
Andrew> commit 67f0714670383a does make me a little nervous, but the
Andrew> gdb-gdb.gdb script isn't something a non-maintainer will be using, so
Andrew> I think we can afford to be a little more aggressive here. If it
Andrew> turns out the 'dir' entries are needed then we can add them back, but
Andrew> actually document why they are needed. Plus, when we add them back we
Andrew> will use @abs_srcdir@ instead of @srcdir@.
Makes sense to me.
Reviewed-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-02-09 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 17:13 Andrew Burgess
2023-02-09 14:01 ` Tom Tromey [this message]
2023-02-11 17:15 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1p7ym2w.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).