public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb: don't use bashism in configure test
@ 2022-06-09  3:37 Sam James
  2022-06-13 12:13 ` Andrew Burgess
  0 siblings, 1 reply; 2+ messages in thread
From: Sam James @ 2022-06-09  3:37 UTC (permalink / raw)
  To: gdb-patches; +Cc: Sam James

Results in configure output like:
```
checking for X... no
/var/tmp/portage/sys-devel/gdb-12.1/work/gdb-12.1/gdb/configure: 18837: test: yes: unexpected operator
checking whether to use babeltrace... auto
```

... when /bin/sh is provided by a POSIX-compliant shell, like dash,
instead of bash.

Signed-off-by: Sam James <sam@gentoo.org>
---
 gdb/configure    | 2 +-
 gdb/configure.ac | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/configure b/gdb/configure
index 1008cbef28b..1b821390801 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -18760,7 +18760,7 @@ else
 fi
 
 
-if test "${enable_libbacktrace}" == "yes"; then
+if test "${enable_libbacktrace}" = "yes"; then
   LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/"
   LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a
 
diff --git a/gdb/configure.ac b/gdb/configure.ac
index e3c19bc8859..bf03b875dfe 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -2113,7 +2113,7 @@ AC_ARG_ENABLE([libbacktrace],
 esac],
 enable_libbacktrace=yes)
 
-if test "${enable_libbacktrace}" == "yes"; then
+if test "${enable_libbacktrace}" = "yes"; then
   LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/"
   LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a
   AC_DEFINE(HAVE_LIBBACKTRACE, 1, [Define if libbacktrace is being used.])
-- 
2.35.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gdb: don't use bashism in configure test
  2022-06-09  3:37 [PATCH] gdb: don't use bashism in configure test Sam James
@ 2022-06-13 12:13 ` Andrew Burgess
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Burgess @ 2022-06-13 12:13 UTC (permalink / raw)
  To: Sam James via Gdb-patches, gdb-patches; +Cc: Sam James

Sam James via Gdb-patches <gdb-patches@sourceware.org> writes:

> Results in configure output like:
> ```
> checking for X... no
> /var/tmp/portage/sys-devel/gdb-12.1/work/gdb-12.1/gdb/configure: 18837: test: yes: unexpected operator
> checking whether to use babeltrace... auto
> ```
>
> ... when /bin/sh is provided by a POSIX-compliant shell, like dash,
> instead of bash.

Thanks, I pushed this for you.

Andrew


>
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
>  gdb/configure    | 2 +-
>  gdb/configure.ac | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/configure b/gdb/configure
> index 1008cbef28b..1b821390801 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -18760,7 +18760,7 @@ else
>  fi
>  
>  
> -if test "${enable_libbacktrace}" == "yes"; then
> +if test "${enable_libbacktrace}" = "yes"; then
>    LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/"
>    LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a
>  
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> index e3c19bc8859..bf03b875dfe 100644
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -2113,7 +2113,7 @@ AC_ARG_ENABLE([libbacktrace],
>  esac],
>  enable_libbacktrace=yes)
>  
> -if test "${enable_libbacktrace}" == "yes"; then
> +if test "${enable_libbacktrace}" = "yes"; then
>    LIBBACKTRACE_INC="-I$srcdir/../libbacktrace/ -I../libbacktrace/"
>    LIBBACKTRACE_LIB=../libbacktrace/.libs/libbacktrace.a
>    AC_DEFINE(HAVE_LIBBACKTRACE, 1, [Define if libbacktrace is being used.])
> -- 
> 2.35.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-13 12:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09  3:37 [PATCH] gdb: don't use bashism in configure test Sam James
2022-06-13 12:13 ` Andrew Burgess

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).