From: Tom Tromey <tom@tromey.com>
To: "Bouhaouel, Mohamed via Gdb-patches" <gdb-patches@sourceware.org>
Cc: "Bouhaouel, Mohamed" <mohamed.bouhaouel@intel.com>,
"tom@tromey.com" <tom@tromey.com>
Subject: Re: [PING][PATCH v3 1/1] gdb, breakpoint: add a destructor to the watchpoint struct
Date: Fri, 15 Sep 2023 11:46:02 -0600 [thread overview]
Message-ID: <87led79vol.fsf@tromey.com> (raw)
In-Reply-To: <DM6PR11MB4457221A2A2334C86736B7C0E4F6A@DM6PR11MB4457.namprd11.prod.outlook.com> (Mohamed via Gdb-patches Bouhaouel's message of "Fri, 15 Sep 2023 07:53:46 +0000")
>>>>> Bouhaouel, Mohamed via Gdb-patches <gdb-patches@sourceware.org> writes:
> I kindly request that you review this patch.
Thank you for the patch.
>> +/* See breakpoint.h. */
>> +
>> +watchpoint::~watchpoint ()
>> +{
>> + /* Make sure to unlink the destroyed watchpoint from the related
>> + breakpoint ring. */
>> +
>> + breakpoint *bpt = this;
>> + while (bpt->related_breakpoint != this)
>> + bpt = bpt->related_breakpoint;
>> +
>> + bpt->related_breakpoint = this->related_breakpoint;
It took me a while to understand this, but I guess it is just the same
as the code in delete_breakpoint.
I think this is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-09-15 17:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 8:10 [PATCH " Mohamed Bouhaouel
2023-09-15 7:53 ` [PING][PATCH " Bouhaouel, Mohamed
2023-09-15 17:46 ` Tom Tromey [this message]
2023-09-19 11:38 ` Bouhaouel, Mohamed
2023-09-19 12:57 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87led79vol.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=mohamed.bouhaouel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).