RE: [PING][PATCH v3 1/1] gdb, breakpoint: add a destructor to the watchpoint struct

["Bouhaouel, Mohamed" <mohamed.bouhaouel@intel.com>]

Hi Tom,

Thanks a lot for your review.  This is my first accepted patch
in GDB.  Can you please push it for me?  I don't have any write access.

I plan to upstream more patches in the future and would like to have
"write after approval" access.  I guess I need to apply for access
in this form https://sourceware.org/cgi-bin/pdw/ps_form.cgi, after
my first patch is pushed!

Thanks again,
Mohamed


> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Friday, September 15, 2023 7:46 PM
> To: Bouhaouel, Mohamed via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Bouhaouel, Mohamed <mohamed.bouhaouel@intel.com>; tom@tromey.com
> Subject: Re: [PING][PATCH v3 1/1] gdb, breakpoint: add a destructor to the
> watchpoint struct
> 
> >>>>> Bouhaouel, Mohamed via Gdb-patches <gdb-patches@sourceware.org>
> writes:
> 
> > I kindly request that you review this patch.
> 
> Thank you for the patch.
> 
> >> +/* See breakpoint.h.  */
> >> +
> >> +watchpoint::~watchpoint ()
> >> +{
> >> +  /* Make sure to unlink the destroyed watchpoint from the related
> >> +     breakpoint ring.  */
> >> +
> >> +  breakpoint *bpt = this;
> >> +  while (bpt->related_breakpoint != this)
> >> +    bpt = bpt->related_breakpoint;
> >> +
> >> +  bpt->related_breakpoint = this->related_breakpoint;
> 
> It took me a while to understand this, but I guess it is just the same
> as the code in delete_breakpoint.
> 
> I think this is ok.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928