From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/dap] Fix exit race
Date: Wed, 14 Feb 2024 08:46:02 -0700 [thread overview]
Message-ID: <87o7cj3v7p.fsf@tromey.com> (raw)
In-Reply-To: <ffab3c70-5446-42c7-a6f2-a6d2766df612@suse.de> (Tom de Vries's message of "Wed, 14 Feb 2024 16:39:43 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> On 2/13/24 19:10, Tom Tromey wrote:
>>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> Fix this by removing the send_gdb("quit").
>> I thought you were sending a different patch for this?
Tom> This is the patch for PR31306, the assertion failure.
>> I think this change by itself is insufficient because it might mean that
>> gdb exits before all the queued responses are emitted.
Tom> As for PR31380, which is about ensuring responses are flushed to
Tom> client before exiting, indeed there's a race between flushing the
Tom> write queue and gdb exiting because of a SIGHUP (which is not caused
Tom> by the send_gdb("quit"), I've mentioned that in the PR.
Alright, it's fine by me if you want to do them separately as well.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-02-14 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 15:01 Tom de Vries
2024-02-13 18:10 ` Tom Tromey
2024-02-14 15:39 ` Tom de Vries
2024-02-14 15:46 ` Tom Tromey [this message]
2024-02-23 17:01 ` Tom Tromey
2024-02-23 21:08 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7cj3v7p.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).