Re: [PATCHv2 4/4] gdb: some int to bool conversion in breakpoint.c

[Andrew Burgess <aburgess@redhat.com>]

Simon Marchi <simark@simark.ca> writes:

> On 10/19/22 09:07, Andrew Burgess via Gdb-patches wrote:
>> Some int to bool conversion in breakpoint.c.  I've only updated the
>> function signatures of static functions, but I've updated some
>> function local variables throughout the file.
>> 
>> The most interesting change is in unduplicated_should_be_inserted,
>> where I've made use of make_scoped_restore to temporarily change the
>> bl->duplicate flag.
>
> This isn't part of this patch.

Ooops, I decided to split this into a separate patch and forgot
to update the commit message.  I fixed this before committing.

>
> Some nits below, but otherwise, the series LGTM:
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
>
>> @@ -1922,7 +1922,7 @@ add_dummy_location (struct breakpoint *b,
>>     watchpoint removal from inferior.  */
>>  
>>  static void
>> -update_watchpoint (struct watchpoint *b, int reparse)
>> +update_watchpoint (struct watchpoint *b, bool reparse)
>
> Update the REPARSE doc, non-zero -> true.
>
>> @@ -4216,7 +4216,7 @@ moribund_breakpoint_here_p (const address_space *aspace, CORE_ADDR pc)
>>  /* Returns non-zero iff BL is inserted at PC, in address space
>>     ASPACE.  */
>>  
>> -static int
>> +static bool
>>  bp_location_inserted_here_p (const struct bp_location *bl,
>
> non-zero -> true in the doc

Thanks, I made the fixes you suggested, and pushed this series.

Andrew