From: Simon Marchi <simark@simark.ca>
To: Andrew Burgess <aburgess@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv2 4/4] gdb: some int to bool conversion in breakpoint.c
Date: Wed, 19 Oct 2022 16:03:10 -0400 [thread overview]
Message-ID: <f4efd0a3-f1db-9a98-e2f7-1369a341d96a@simark.ca> (raw)
In-Reply-To: <62e73978fa2b623f42e567d34429104fe70304c5.1666184729.git.aburgess@redhat.com>
On 10/19/22 09:07, Andrew Burgess via Gdb-patches wrote:
> Some int to bool conversion in breakpoint.c. I've only updated the
> function signatures of static functions, but I've updated some
> function local variables throughout the file.
>
> The most interesting change is in unduplicated_should_be_inserted,
> where I've made use of make_scoped_restore to temporarily change the
> bl->duplicate flag.
This isn't part of this patch.
Some nits below, but otherwise, the series LGTM:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
> @@ -1922,7 +1922,7 @@ add_dummy_location (struct breakpoint *b,
> watchpoint removal from inferior. */
>
> static void
> -update_watchpoint (struct watchpoint *b, int reparse)
> +update_watchpoint (struct watchpoint *b, bool reparse)
Update the REPARSE doc, non-zero -> true.
> @@ -4216,7 +4216,7 @@ moribund_breakpoint_here_p (const address_space *aspace, CORE_ADDR pc)
> /* Returns non-zero iff BL is inserted at PC, in address space
> ASPACE. */
>
> -static int
> +static bool
> bp_location_inserted_here_p (const struct bp_location *bl,
non-zero -> true in the doc
Simon
next prev parent reply other threads:[~2022-10-19 20:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 9:32 [PATCH 0/4] Const args, int->bool, and scoped_restore " Andrew Burgess
2022-10-05 9:32 ` [PATCH 1/4] gdb: make some bp_location arguments const " Andrew Burgess
2022-10-18 13:46 ` Bruno Larsen
2022-10-05 9:32 ` [PATCH 2/4] gdb: used scoped_restore_frame in update_watchpoint Andrew Burgess
2022-10-05 9:32 ` [PATCH 3/4] gdb: make use of scoped_restore in unduplicated_should_be_inserted Andrew Burgess
2022-10-05 9:32 ` [PATCH 4/4] gdb: some int to bool conversion in breakpoint.c Andrew Burgess
2022-10-19 13:07 ` [PATCHv2 0/4] Const args, int->bool, and scoped_restore " Andrew Burgess
2022-10-19 13:07 ` [PATCHv2 1/4] gdb: make some bp_location arguments const " Andrew Burgess
2022-10-19 13:07 ` [PATCHv2 2/4] gdb: used scoped_restore_frame in update_watchpoint Andrew Burgess
2022-10-19 13:07 ` [PATCHv2 3/4] gdb: make use of scoped_restore in unduplicated_should_be_inserted Andrew Burgess
2022-10-19 13:07 ` [PATCHv2 4/4] gdb: some int to bool conversion in breakpoint.c Andrew Burgess
2022-10-19 20:03 ` Simon Marchi [this message]
2022-10-20 15:48 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4efd0a3-f1db-9a98-e2f7-1369a341d96a@simark.ca \
--to=simark@simark.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).