* [PATCH] Remove value::copy call from gdbpy_get_varobj_pretty_printer
@ 2023-08-04 14:00 Tom Tromey
2023-08-22 16:43 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-08-04 14:00 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
I noticed a call to value::copy in gdbpy_get_varobj_pretty_printer,
and I couldn't figure out why it was there. I think maybe it came
from the time when value_to_value_object would release values from the
value chain -- but that was removed in commit f3d3bbbc.
This patch removes this call. Regression tested on x86-64 Fedora 36.
---
gdb/python/py-prettyprint.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/gdb/python/py-prettyprint.c b/gdb/python/py-prettyprint.c
index 29ae0205ec7..cccc94e319b 100644
--- a/gdb/python/py-prettyprint.c
+++ b/gdb/python/py-prettyprint.c
@@ -661,15 +661,6 @@ apply_varobj_pretty_printer (PyObject *printer_obj,
gdbpy_ref<>
gdbpy_get_varobj_pretty_printer (struct value *value)
{
- try
- {
- value = value->copy ();
- }
- catch (const gdb_exception &except)
- {
- GDB_PY_HANDLE_EXCEPTION (except);
- }
-
gdbpy_ref<> val_obj (value_to_value_object (value));
if (val_obj == NULL)
return NULL;
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove value::copy call from gdbpy_get_varobj_pretty_printer
2023-08-04 14:00 [PATCH] Remove value::copy call from gdbpy_get_varobj_pretty_printer Tom Tromey
@ 2023-08-22 16:43 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2023-08-22 16:43 UTC (permalink / raw)
To: Tom Tromey via Gdb-patches; +Cc: Tom Tromey
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> I noticed a call to value::copy in gdbpy_get_varobj_pretty_printer,
Tom> and I couldn't figure out why it was there. I think maybe it came
Tom> from the time when value_to_value_object would release values from the
Tom> value chain -- but that was removed in commit f3d3bbbc.
Tom> This patch removes this call. Regression tested on x86-64 Fedora 36.
I'm checking this in.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-22 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-04 14:00 [PATCH] Remove value::copy call from gdbpy_get_varobj_pretty_printer Tom Tromey
2023-08-22 16:43 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).