From: Tom Tromey <tom@tromey.com>
To: "Rohr, Stephan via Gdb-patches" <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,
"Rohr, Stephan" <stephan.rohr@intel.com>,
Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH v3 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values casted to different type.
Date: Mon, 09 Jan 2023 12:28:36 -0700 [thread overview]
Message-ID: <87tu0z8q3f.fsf@tromey.com> (raw)
In-Reply-To: <DM6PR11MB4564B3D669F947EA5D9F4A6093FE9@DM6PR11MB4564.namprd11.prod.outlook.com> (Stephan via Gdb-patches Rohr's message of "Mon, 9 Jan 2023 08:12:25 +0000")
> There was a discussion with Simon whether the value cast should update the
> enclosing type. Simon tried it out but as I understood he's also not clear on
> what the right answer answers are. From my point of view, this would also
> be a separate patch.
Ok, that's fair.
I think the patch is ok.
Tom
next prev parent reply other threads:[~2023-01-09 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 13:12 [PATCH v3 0/1] " Stephan Rohr
2022-12-21 13:12 ` [PATCH v3 1/1] " Stephan Rohr
2023-01-05 19:52 ` Tom Tromey
2023-01-06 19:22 ` Simon Marchi
2023-01-06 20:36 ` Tom Tromey
2023-01-09 8:12 ` Rohr, Stephan
2023-01-09 19:28 ` Tom Tromey [this message]
2023-01-10 9:29 ` Rohr, Stephan
2023-01-10 21:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu0z8q3f.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=stephan.rohr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).