From: "Rohr, Stephan" <stephan.rohr@intel.com>
To: Tom Tromey <tom@tromey.com>,
"Rohr, Stephan via Gdb-patches" <gdb-patches@sourceware.org>
Cc: Simon Marchi <simark@simark.ca>
Subject: RE: [PATCH v3 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values casted to different type.
Date: Tue, 10 Jan 2023 09:29:14 +0000 [thread overview]
Message-ID: <DM6PR11MB4564D7BCFAF84099D9BD5F9793FF9@DM6PR11MB4564.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87tu0z8q3f.fsf@tromey.com>
Hi Tom.
> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Monday, January 9, 2023 8:29 PM
> To: Rohr, Stephan via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tom@tromey.com>; Rohr, Stephan
> <stephan.rohr@intel.com>; Simon Marchi <simark@simark.ca>
> Subject: Re: [PATCH v3 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values
> casted to different type.
>
> > There was a discussion with Simon whether the value cast should update
> > the enclosing type. Simon tried it out but as I understood he's also
> > not clear on what the right answer answers are. From my point of
> > view, this would also be a separate patch.
>
> Ok, that's fair.
> I think the patch is ok.
>
> Tom
Thank you for your review. This is my first patch. Can you push it for me?
I don't have any write access.
I plan to upstream more patches in the future and would like to have
"write after approval" access. Could I put your email address in the field
which says "email address of person who approved request" in the application
form at https://sourceware.org/cgi-bin/pdw/ps_form.cgi ?
Thanks
Stephan
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2023-01-10 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 13:12 [PATCH v3 0/1] " Stephan Rohr
2022-12-21 13:12 ` [PATCH v3 1/1] " Stephan Rohr
2023-01-05 19:52 ` Tom Tromey
2023-01-06 19:22 ` Simon Marchi
2023-01-06 20:36 ` Tom Tromey
2023-01-09 8:12 ` Rohr, Stephan
2023-01-09 19:28 ` Tom Tromey
2023-01-10 9:29 ` Rohr, Stephan [this message]
2023-01-10 21:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4564D7BCFAF84099D9BD5F9793FF9@DM6PR11MB4564.namprd11.prod.outlook.com \
--to=stephan.rohr@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).