From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
Stephan Rohr via Gdb-patches <gdb-patches@sourceware.org>,
Stephan Rohr <stephan.rohr@intel.com>
Subject: Re: [PATCH v3 1/1] gdb/dwarf2: Fix 'rw_pieced_value' for values casted to different type.
Date: Fri, 06 Jan 2023 13:36:56 -0700 [thread overview]
Message-ID: <87v8lj763b.fsf@tromey.com> (raw)
In-Reply-To: <1007a4fe-75d7-76e0-2922-5e1f1dba4952@simark.ca> (Simon Marchi's message of "Fri, 6 Jan 2023 14:22:16 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> I don't have a strong opinion on the matter, I don't know if one
Simon> solution is more corrent than the other. The thing is, I can't explain
Simon> the logic behind the existing assert. It's missing a comment explaining
Simon> why it would be a bad thing to "create a lazy value with an enclosing
Simon> type". If we can't add such a justification, I think it's ok to remove
Simon> it...
I think the idea is that the enclosing type stuff is all there for "set
print object on" -- and so for a value to have an enclosing type, it
must already have contents, because the enclosing type is the runtime
type, which can only be determined by reading memory.
Tom
next prev parent reply other threads:[~2023-01-06 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 13:12 [PATCH v3 0/1] " Stephan Rohr
2022-12-21 13:12 ` [PATCH v3 1/1] " Stephan Rohr
2023-01-05 19:52 ` Tom Tromey
2023-01-06 19:22 ` Simon Marchi
2023-01-06 20:36 ` Tom Tromey [this message]
2023-01-09 8:12 ` Rohr, Stephan
2023-01-09 19:28 ` Tom Tromey
2023-01-10 9:29 ` Rohr, Stephan
2023-01-10 21:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8lj763b.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=stephan.rohr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).