From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb: check for groups with duplicate names in reggroups:add
Date: Tue, 18 Oct 2022 12:42:58 -0600 [thread overview]
Message-ID: <87v8ohgeh9.fsf@tromey.com> (raw)
In-Reply-To: <20221018141733.29298-1-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Tue, 18 Oct 2022 10:17:33 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> In the downstream ROCm GDB port, we would create multiple register
Simon> groups with duplicate names. While it did not really hurt, it certainly
Simon> wasn't the intent. And I don't think it ever makes sense to do so.
Simon> To catch these, change the assert in reggroups::add to check for
Simon> duplicate names. It's no longer necessary to check for duplicate
Simon> reggroup pointers, because adding the same group twice would be caught
Simon> by the duplicate name check.
I haven't looked but would it be possible for malformed XML from the
target to trigger this assert?
Tom
next prev parent reply other threads:[~2022-10-18 18:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:17 Simon Marchi
2022-10-18 18:42 ` Tom Tromey [this message]
2022-10-18 18:54 ` Simon Marchi
2022-10-18 19:01 ` Tom Tromey
2022-10-18 20:47 ` Simon Marchi
2022-10-19 1:54 ` Tom Tromey
2022-10-19 2:12 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8ohgeh9.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).