From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb: check for groups with duplicate names in reggroups:add
Date: Tue, 18 Oct 2022 16:47:03 -0400 [thread overview]
Message-ID: <b627afb1-e155-5582-7ef7-f8c81832a25b@simark.ca> (raw)
In-Reply-To: <87r0z5gdmb.fsf@tromey.com>
On 10/18/22 15:01, Tom Tromey wrote:
> Simon> I don't think so, because the target description support code creates
> Simon> the groups as it finds them while iterating registers.
>
> Thanks, in that case this seems like a good idea to me.
>
> Tom
I am asking, because these things are still new, so better safe than
sorry: are you fine with me adding your Approved-By?
Simon
next prev parent reply other threads:[~2022-10-18 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 14:17 Simon Marchi
2022-10-18 18:42 ` Tom Tromey
2022-10-18 18:54 ` Simon Marchi
2022-10-18 19:01 ` Tom Tromey
2022-10-18 20:47 ` Simon Marchi [this message]
2022-10-19 1:54 ` Tom Tromey
2022-10-19 2:12 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b627afb1-e155-5582-7ef7-f8c81832a25b@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).