public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* 4b610737f02 Handle copy relocations
@ 2022-10-18 13:25 Metzger, Markus T
  2022-10-18 13:25 ` Metzger, Markus T
  2022-10-18 14:38 ` Tom Tromey
  0 siblings, 2 replies; 3+ messages in thread
From: Metzger, Markus T @ 2022-10-18 13:25 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

Hello Tom,

        4b610737f02 Handle copy relocations

makes get_symbol_address() and get_msymbol_address() search objfiles

for a 'better' match to handle copy relocations.



With linker namespaces, however, it may cause a wrong address to be
read after symbol lookup actually found the correct symbol.  This can
be seen, for example, with gdb.base/dlmopen.exp when compiled with
clang.

Do you maybe see a different way of supporting copy relocations that
would not require fixing up the symbol when querying its address?

thanks,
markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

^ permalink raw reply	[flat|nested] 3+ messages in thread

* 4b610737f02 Handle copy relocations
  2022-10-18 13:25 4b610737f02 Handle copy relocations Metzger, Markus T
@ 2022-10-18 13:25 ` Metzger, Markus T
  2022-10-18 14:38 ` Tom Tromey
  1 sibling, 0 replies; 3+ messages in thread
From: Metzger, Markus T @ 2022-10-18 13:25 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

Hello Tom,

        4b610737f02 Handle copy relocations

makes get_symbol_address() and get_msymbol_address() search objfiles

for a 'better' match to handle copy relocations.



With linker namespaces, however, it may cause a wrong address to be
read after symbol lookup actually found the correct symbol.  This can
be seen, for example, with gdb.base/dlmopen.exp when compiled with
clang.

Do you maybe see a different way of supporting copy relocations that
would not require fixing up the symbol when querying its address?

thanks,
markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 4b610737f02 Handle copy relocations
  2022-10-18 13:25 4b610737f02 Handle copy relocations Metzger, Markus T
  2022-10-18 13:25 ` Metzger, Markus T
@ 2022-10-18 14:38 ` Tom Tromey
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2022-10-18 14:38 UTC (permalink / raw)
  To: Metzger, Markus T; +Cc: Tom Tromey, gdb-patches

>         4b610737f02 Handle copy relocations

> With linker namespaces, however, it may cause a wrong address to be
> read after symbol lookup actually found the correct symbol.  This can
> be seen, for example, with gdb.base/dlmopen.exp when compiled with
> clang.

> Do you maybe see a different way of supporting copy relocations that
> would not require fixing up the symbol when querying its address?

I'm not really sure how this ought to work when there are linker
namespaces, but basically what gdb needs to do is mimic whatever ldd
does in this situation.

I think copy relocations by their nature require some kind of symbol
search.

Tom

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-18 14:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-18 13:25 4b610737f02 Handle copy relocations Metzger, Markus T
2022-10-18 13:25 ` Metzger, Markus T
2022-10-18 14:38 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).