public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org,  Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/6] gdb: add includes in target-debug.h
Date: Fri, 19 Apr 2024 13:06:11 -0600	[thread overview]
Message-ID: <87wmotuq8s.fsf@tromey.com> (raw)
In-Reply-To: <20240417205426.2030615-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Wed, 17 Apr 2024 16:54:06 -0400")

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> Editing target-debug.h with clangd shows a bunch of errors.  Add some
Simon> includes to fix that (make target-debug.h include what it uses).

I think generally this kind of thing is obvious, unless adding the
include is somehow problematic or weird.

Tom

  parent reply	other threads:[~2024-04-19 19:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-17 20:54 Simon Marchi
2024-04-17 20:54 ` [PATCH 2/6] gdb: convert target debug macros to functions Simon Marchi
2024-04-19 19:12   ` Tom Tromey
2024-04-17 20:54 ` [PATCH 3/6] gdb: make target debug functions return std::string Simon Marchi
2024-04-19 19:20   ` Tom Tromey
2024-04-19 19:41     ` Simon Marchi
2024-04-19 20:19       ` Tom Tromey
2024-04-17 20:54 ` [PATCH 4/6] gdb: make debug_target use one-liners Simon Marchi
2024-04-19 19:23   ` Tom Tromey
2024-04-17 20:54 ` [PATCH 5/6] gdb: make regcache::debug_print_register return a string Simon Marchi
2024-04-19 19:24   ` Tom Tromey
2024-04-19 19:45     ` Simon Marchi
2024-04-17 20:54 ` [PATCH 6/6] gdb: add target_debug_printf and target_debug_printf_nofunc Simon Marchi
2024-04-19 19:27   ` Tom Tromey
2024-04-19 19:06 ` Tom Tromey [this message]
2024-04-19 19:07   ` [PATCH 1/6] gdb: add includes in target-debug.h Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmotuq8s.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@efficios.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).