From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 6/6] gdb: add target_debug_printf and target_debug_printf_nofunc
Date: Fri, 19 Apr 2024 13:27:35 -0600 [thread overview]
Message-ID: <87bk65up94.fsf@tromey.com> (raw)
In-Reply-To: <20240417205426.2030615-6-simon.marchi@polymtl.ca> (Simon Marchi's message of "Wed, 17 Apr 2024 16:54:11 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> Add the `target_debug_printf` and `target_debug_printf_nofunc` macros
Simon> and use them when outputting debug messages depending on `targetdebug`.
Simon> I opted for `target_debug_printf_nofunc` to follow the current style
Simon> where the function name is already printed, along with the arguments.
Simon> Modify the debug printfs in the `debug_target` methods (generated by
Simon> `make-target-delegates.py`) to use `target_debug_printf_nofunc` as well.
Simon> This makes the "target" debug prints integrate nicely with the other
Simon> debug prints that use the "new" debug print system:
Thanks, this looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-04-19 19:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 20:54 [PATCH 1/6] gdb: add includes in target-debug.h Simon Marchi
2024-04-17 20:54 ` [PATCH 2/6] gdb: convert target debug macros to functions Simon Marchi
2024-04-19 19:12 ` Tom Tromey
2024-04-17 20:54 ` [PATCH 3/6] gdb: make target debug functions return std::string Simon Marchi
2024-04-19 19:20 ` Tom Tromey
2024-04-19 19:41 ` Simon Marchi
2024-04-19 20:19 ` Tom Tromey
2024-04-17 20:54 ` [PATCH 4/6] gdb: make debug_target use one-liners Simon Marchi
2024-04-19 19:23 ` Tom Tromey
2024-04-17 20:54 ` [PATCH 5/6] gdb: make regcache::debug_print_register return a string Simon Marchi
2024-04-19 19:24 ` Tom Tromey
2024-04-19 19:45 ` Simon Marchi
2024-04-17 20:54 ` [PATCH 6/6] gdb: add target_debug_printf and target_debug_printf_nofunc Simon Marchi
2024-04-19 19:27 ` Tom Tromey [this message]
2024-04-19 19:06 ` [PATCH 1/6] gdb: add includes in target-debug.h Tom Tromey
2024-04-19 19:07 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bk65up94.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).