Re: [PATCH 3/6] gdb: make target debug functions return std::string

[Simon Marchi <simon.marchi@efficios.com>]

On 2024-04-19 15:20, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@efficios.com>
> Simon> Change the functions in target-debug.h to return string representations
> Simon> in an std::string, such that they don't need to know how the printing
> Simon> part is done.  This also helps the following patch that makes the debug
> Simon> prints in debug_target one-liners.
> 
> Simon> Update target-delegates.c (through make-target-delegates.py) to do the
> Simon> printing.
> 
> Simon> Add an overload of gdb_puts to avoid using `.c_str ()`.
> 
> Simon> +      string_appendf (s, " %s",
> Simon> +		      gdb_signal_to_name (static_cast<gdb_signal>(i)));
> Simon> +
> Simon> +  string_appendf (s, " }");
> 
> I think it would clearer if these were += instead of string_appendf.
> It would also mean avoiding a trip through the printf code.

Ok, I changed 3 instances of this to use += (I think you only meant
these cases that append constant strings, right?).

Simon