public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] Check for listeners in emit_exiting_event
@ 2022-06-03 16:46 Tom Tromey
  2022-06-15 19:51 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2022-06-03 16:46 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

I noticed that emit_exiting_event does not check whether there are any
listeners before creating the event object.  All other event emitters
do this, so this patch updates this one as well.
---
 gdb/python/python.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gdb/python/python.c b/gdb/python/python.c
index 9bef2252e88..844e1165de0 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -1936,6 +1936,9 @@ init__gdb_module (void)
 static int
 emit_exiting_event (int exit_code)
 {
+  if (evregpy_no_listeners_p (gdb_py_events.gdb_exiting))
+    return 0;
+
   gdbpy_ref<> event_obj = create_event_object (&gdb_exiting_event_object_type);
   if (event_obj == nullptr)
     return -1;
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Check for listeners in emit_exiting_event
  2022-06-03 16:46 [PATCH] Check for listeners in emit_exiting_event Tom Tromey
@ 2022-06-15 19:51 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2022-06-15 19:51 UTC (permalink / raw)
  To: Tom Tromey via Gdb-patches; +Cc: Tom Tromey

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> I noticed that emit_exiting_event does not check whether there are any
Tom> listeners before creating the event object.  All other event emitters
Tom> do this, so this patch updates this one as well.

I'm checking this in now.

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-06-15 19:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-03 16:46 [PATCH] Check for listeners in emit_exiting_event Tom Tromey
2022-06-15 19:51 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).