From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH v2] [gdb/tui] Show regs when switching to regs layout
Date: Fri, 08 Dec 2023 08:29:24 -0700 [thread overview]
Message-ID: <87y1e4hfvv.fsf@tromey.com> (raw)
In-Reply-To: <20231126075250.31557-1-tdevries@suse.de> (Tom de Vries's message of "Sun, 26 Nov 2023 08:52:50 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> void
Tom> tui_data_window::rerender ()
Tom> {
Tom> + /* Calling check_register_value calls rerender again. We use this counter
Tom> + to prevent enless recursion. */
Tom> + static int in_rerender;
There's a typo, the function is check_register_values (missing an "s" in
the comment).
However, it seems bad to need new state for this.
This triggered a memory -- there's already weird state in this area, see
tui-hooks.c:tui_refreshing_registers. I have never understood why that
is needed.
I wonder if this can be untangled.
Tom
next prev parent reply other threads:[~2023-12-08 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 7:52 Tom de Vries
2023-11-27 12:27 ` Alexandra Petlanova Hajkova
2023-12-08 15:29 ` Tom Tromey [this message]
2023-12-09 8:30 ` Tom de Vries
2023-12-09 10:01 ` Tom de Vries
2023-12-16 1:40 ` Tom Tromey
2023-12-16 8:34 ` Tom de Vries
2023-12-17 17:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1e4hfvv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).