From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] [gdb/tui] Show regs when switching to regs layout
Date: Sat, 16 Dec 2023 09:34:01 +0100 [thread overview]
Message-ID: <9d79f40b-816b-470c-8f30-5096f08cbe21@suse.de> (raw)
In-Reply-To: <87edfm6i20.fsf@tromey.com>
On 12/16/23 02:40, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> How about this approach?
>
> Tom> Rather than adding global state, it adds a function parameter.
>
> Tom> It's currently called toplevel, though I've also consider "active".
>
> This is fine by me.
>
> Really I suspect the register window refresh code can be untangled and
> not need any of this, but it's fine to just fix the bug and move on.
>
I suspect that as well, but unfortunately I don't understand how yet.
> Approved-By: Tom Tromey <tom@tromey.com>
Thanks for the review, pushed.
- Tom
next prev parent reply other threads:[~2023-12-16 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 7:52 Tom de Vries
2023-11-27 12:27 ` Alexandra Petlanova Hajkova
2023-12-08 15:29 ` Tom Tromey
2023-12-09 8:30 ` Tom de Vries
2023-12-09 10:01 ` Tom de Vries
2023-12-16 1:40 ` Tom Tromey
2023-12-16 8:34 ` Tom de Vries [this message]
2023-12-17 17:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d79f40b-816b-470c-8f30-5096f08cbe21@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).